Skip to content

[HDInsight] imporve hdinsight test coverage #28344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[HDInsight] imporve hdinsight test coverage #28344

wants to merge 6 commits into from
+17,827 −12,437

Conversation

2258093686
Copy link
Member

Description

Increase test coverage from 40% to 90%

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 03:58
@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

This comment was marked as outdated.

Sign in to view

@2258093686 2258093686 marked this pull request as draft August 7, 2025 04:03
@2258093686 2258093686 requested a review from Copilot August 7, 2025 04:11
Copilot

This comment was marked as outdated.

Sign in to view

@2258093686 2258093686 requested a review from Copilot August 7, 2025 05:42
Copilot

This comment was marked as outdated.

Sign in to view

@2258093686 2258093686 requested a review from Copilot August 7, 2025 05:58
Copilot

This comment was marked as outdated.

Sign in to view

@2258093686 2258093686 requested a review from Copilot August 7, 2025 06:36
Copilot

This comment was marked as outdated.

Sign in to view

@2258093686 2258093686 assigned 2258093686 and unassigned 2258093686 Aug 7, 2025
@2258093686 2258093686 marked this pull request as ready for review August 7, 2025 07:10
@2258093686 2258093686 requested a review from Copilot August 12, 2025 06:16
Copilot
Copilot AI reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves HDInsight test coverage by increasing test coverage from 40% to 90% through extensive updates to existing test scenarios and the addition of new test scenarios that provide better coverage of HDInsight functionality.

  • Addition of new test scenarios for job management commands and cluster management operations
  • Updates to test configuration to use more consistent parameters and remove test skips
  • Addition of new configuration test scenarios for cluster creation through configuration pipelining

Reviewed Changes

Copilot reviewed 10 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
TestManagementCluster.json New session recording file for testing management cluster operations
HDInsightScriptActionTests.ps1 Added Version parameter to cluster creation
HDInsightMonitoringTests.ps1 Changed location from "EastUS" to "East Asia" and added Version parameter
HDInsightConfigurationTests.ps1 Added new test function for creating clusters through configuration pipelining
HDInsightConfigurationTests.cs Added test method binding for configuration pipelining test
HDInsightClusterTests.ps1 Added job management test commands and management cluster test, removed test skipping
HDInsightClusterTests.cs Added test method bindings and removed Skip attributes
HDInsightAzureMonitorTests.ps1 Simplified test to use existing cluster instead of creating new one
HDInsightAzureMonitorTests.cs Removed Skip attribute from test
Common.ps1 Updated default parameters to use consistent test resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2258093686 @v-yukunli